On Dec 6, 2013, at 6:01 PM, Claudio Freire <klaussfre...@gmail.com> wrote:

> On Fri, Dec 6, 2013 at 3:50 PM, Michael Bayer <mike...@zzzcomputing.com> 
> wrote:
>> +            except:
>> +                self._overflow -= 1
>> +                raise
> 
> 
> That also needs to aquire the lock.

I think I’m going to make a different object out of “overflow” just to make 
this easier to follow.  It just needs to be an atomic counter that goes between 
M and N and tells you “yes” or “no”.   the code right now is very inlined as it 
originates from a certain performance-crazy time in SQLA’s history, but 
connection pool checkouts aren’t really per-statement these days.


Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to