I've added you to the "contributors" group so you should have access now.
On 05/23/2016 12:45 PM, Mark Sandan wrote:
No worries, I'll put up a reference to the PR and gerrit proposal in case anybody wants to chime in. The change is proposed in git PR #275 <https://github.com/zzzeek/sqlalchemy/pull/275> and in gerrit <https://gerrit.sqlalchemy.org/#/c/85/1> (which I'm still getting used too). On Sunday, May 22, 2016 at 8:23:14 PM UTC-7, Mike Bayer wrote: OK so we'll probably just add the hook you've proposed. I've not had anytime to work on a computer for like five days straight which puts me super behind, ill try to get to your PR soon. On 05/19/2016 01:08 PM, Mark Sandan wrote: > Sure, the Teradata database has create table ddl where you can specify > certain options that are separated by commas. We have a reference manual > available online specifying the full DDL here > <https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=0ahUKEwjZkreizubMAhVIXh4KHWp0DrAQFggdMAA&url=http%3A%2F%2Ftunweb.teradata.ws%2Ftunstudent%2FTeradataUserManuals%2FSQL_Reference_--_Data_Definition_Syntax_Example.pdf&usg=AFQjCNFEIVA1TfbRXNV_hQfCVNBe7gZt3g&sig2=dPP1GmBUBEyB186Pkh6HmA <https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=0ahUKEwjZkreizubMAhVIXh4KHWp0DrAQFggdMAA&url=http%3A%2F%2Ftunweb.teradata.ws%2Ftunstudent%2FTeradataUserManuals%2FSQL_Reference_--_Data_Definition_Syntax_Example.pdf&usg=AFQjCNFEIVA1TfbRXNV_hQfCVNBe7gZt3g&sig2=dPP1GmBUBEyB186Pkh6HmA>> (see > page 383 for the full syntax). Here is some example DDL: > > | > CREATE TABLE t1 ,FALLBACK , > NO BEFORE JOURNAL, > NO AFTER JOURNAL, > CHECKSUM = DEFAULT, > DEFAULT MERGEBLOCKRATIO > ( > c1 VARCHAR(128) NOT NULL, > Id BYTE(4) NOT NULL, > OwnerId BYTE(4) NOT NULL > ) > UNIQUE PRIMARY INDEX ( c1 ) > UNIQUE INDEX ( Id ); > | > > > > On Thursday, May 19, 2016 at 8:31:49 AM UTC-7, Mike Bayer wrote: > > saw your pull request, just curious what database / DDL is this? Just > like to see the finished product that you're going for. > > > > On 05/18/2016 09:19 PM, Mark Sandan wrote: > > Hi, I'm implementing a dialect for sqlalchemy and would like to add > > options before the '(' but after the table name in visit_create. I > know > > I can just subclass visit_create in my ddl compiler but it seems > kind of > > silly since I'd be making a small change. Something like the > following: > > | > > > > > > defvisit_create_table(self,create): > > table =create.element > > preparer =self.preparer > > > > text ="\nCREATE " > > iftable._prefixes: > > text +=" ".join(table._prefixes)+" " > > text +="TABLE "+preparer.format_table(table)+" > "+table_options(table)+" (" > > > > | > > > > table_options would be a function in the ddl compiler provided by the > > dialect that takes dialect specific keywords and simply appends comma > > delimited values. I essentially need something like the 'prefixes' > > keyword in Table but for after the table name and before the left > > parens. Any ideas? > > > > -- > > You received this message because you are subscribed to the Google > > Groups "sqlalchemy" group. > > To unsubscribe from this group and stop receiving emails from it, > send > > an email to sqlalchemy+...@googlegroups.com <javascript:> > > <mailto:sqlalchemy+unsubscr...@googlegroups.com <javascript:> <javascript:>>. > > To post to this group, send email to sqlal...@googlegroups.com > <javascript:> > > <mailto:sqlal...@googlegroups.com <javascript:>>. > > Visit this group at https://groups.google.com/group/sqlalchemy <https://groups.google.com/group/sqlalchemy> > <https://groups.google.com/group/sqlalchemy <https://groups.google.com/group/sqlalchemy>>. > > For more options, visit https://groups.google.com/d/optout <https://groups.google.com/d/optout> > <https://groups.google.com/d/optout <https://groups.google.com/d/optout>>. > > -- > You received this message because you are subscribed to the Google > Groups "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to sqlalchemy+...@googlegroups.com <javascript:> > <mailto:sqlalchemy+unsubscr...@googlegroups.com <javascript:>>. > To post to this group, send email to sqlal...@googlegroups.com <javascript:> > <mailto:sqlal...@googlegroups.com <javascript:>>. > Visit this group at https://groups.google.com/group/sqlalchemy <https://groups.google.com/group/sqlalchemy>. > For more options, visit https://groups.google.com/d/optout <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sqlalchemy+unsubscr...@googlegroups.com <mailto:sqlalchemy+unsubscr...@googlegroups.com>. To post to this group, send email to sqlalchemy@googlegroups.com <mailto:sqlalchemy@googlegroups.com>. Visit this group at https://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sqlalchemy+unsubscr...@googlegroups.com. To post to this group, send email to sqlalchemy@googlegroups.com. Visit this group at https://groups.google.com/group/sqlalchemy. For more options, visit https://groups.google.com/d/optout.
