Thanks for the patch. I have a couple questions (pretty much for my own benefit and maybe others have some thoughts on the matter).
1. In mk_name(), the line you added was: $basename =~ s/\./_/g; Is this converting periods between the schema and the table? If so, why are you keeping the schema name in there. Does a constraint/index need to be named uniquely across all schemas? A potential problem could arise if a schema has a name larger than the max name size and then you could have several identically named constraints/indexes. 2. This is just clarification due to my lack of SQLite knowlege. In the other set of changes, did you strip the schema because a schema qualified table name is not allowed for creating a constraint/index? Thanks again for the work you've put in and for giving it back to the community. Ben On Wed, 2007-12-19 at 11:16 -0500, Nathan Gray wrote: > I've been using DBIC ResultSource table definition classes built for > Oracle with SQLite during testing. > > I ran into a snag when the table name includes a schema name and > unique constraints are added. > > This patch fixes the SQL generated for SQLite index creation. > > I looked for a place to add a test for schema names in index creation, > but did not see any obvious place. > > -kolibrie > > ------------------------------------------------------------------------- > SF.Net email is sponsored by: > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services > for just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace -- sqlfairy-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
