Thanks for the response. I've gone ahead and committed your changes. If you hear back from the SQLite mailing list, and they tell you something contrary to your patch, then we can modify the code then.
Thanks, Ben On Thu, 2007-12-20 at 08:37 -0500, Nathan Gray wrote: > On Wed, Dec 19, 2007 at 03:58:25PM -0600, Ben Faga wrote: > > Thanks for the patch. > > > > I have a couple questions (pretty much for my own benefit and maybe > > others have some thoughts on the matter). > > > > 1. In mk_name(), the line you added was: > > > > $basename =~ s/\./_/g; > > > > Is this converting periods between the schema and the table? If so, why > > are you keeping the schema name in there. Does a constraint/index need > > to be named uniquely across all schemas? > > The period must be there between the schema and the tablename. In my > debugging, it looked like $basename had some field names concatenated > together, and then the schema.tablename stuck on the end. So that fix > was to remove the second period in the name of the index. > > > A potential problem could arise if a schema has a name larger than the > > max name size and then you could have several identically named > > constraints/indexes. > > That would be bad. That should not occur for how DBIC was using it. > I'm not sure if there are other tools that send different information to > those methods, or how those are documented. > > > 2. This is just clarification due to my lack of SQLite knowlege. In > > the other set of changes, did you strip the schema because a schema > > qualified table name is not allowed for creating a constraint/index? > > Exactly. For some reason the schema is allowed on the name of the > index, but there can be no schema name on the table. It uses the same > schema as you use for the index, so it knows which table to attach to, > if there are several tables with the same name. > > I wrote to the SQLite list and asked them if they might clarify their > documentation a little bit, and perhaps allow the schema name on the > table. > > > Thanks again for the work you've put in and for giving it back to the > > community. > > You're welcome. I'm glad when I find something that I can help with. > > -kolibrie > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ -- sqlfairy-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
