On 01/25/2011 07:30 PM, Black, Michael (IS) wrote: > Yes -- MSVC spits out a bunch of constant expression warnings. Most are > bogus (e.g. while (1)). I looked at them all. > > In this case if it's a compile-time option (which it is) wouldn't you > normally put it in an #if block?
Normally. But in this case we need the C compiler to analyze and optimize the expression and determine whether it evaluates to 0 or 1 on the target. The pre-processor can't do it. > It confused me when looking at the code as one or the other block will never > execute....dead code. > > And...while looking at where it's called I noticed > > sqlite3Prepare16 > const void *zSql, /* UTF-8 encoded SQL statement. */ > > sqlite3_prepare16 > const void *zSql, /* UTF-8 encoded SQL statement. */ > > Should be UTF-16 in the comment? That would match the prototypes. Should be. Yes. Dan. _______________________________________________ sqlite-users mailing list sqlite-users@sqlite.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
