[
https://issues.apache.org/jira/browse/SQOOP-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137758#comment-13137758
]
[email protected] commented on SQOOP-377:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2589/#review2901
-----------------------------------------------------------
Thanks for the patch, Arvind! Only two comments.
/src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java
<https://reviews.apache.org/r/2589/#comment6481>
Remove copyright notice.
/src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java
<https://reviews.apache.org/r/2589/#comment6482>
Add @deprecated tag.
- Bilung
On 2011-10-27 20:41:29, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2589/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 20:41:29)
bq.
bq.
bq. Review request for Sqoop and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Migrated the mapreduce.db package to org.apache.sqoop namespace.
bq.
bq.
bq. This addresses bug SQOOP-377.
bq. https://issues.apache.org/jira/browse/SQOOP-377
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java
1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java
1189822
bq.
/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
1189822
bq.
/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java
1189822
bq. /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822
bq. /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java
PRE-CREATION
bq.
/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
PRE-CREATION
bq.
/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java
PRE-CREATION
bq. /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION
bq. /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java
1189822
bq. /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822
bq. /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java
PRE-CREATION
bq. /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2589/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran all unit and thirdparty tests.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Migrate mapreduce.db package to new name space
> ----------------------------------------------
>
> Key: SQOOP-377
> URL: https://issues.apache.org/jira/browse/SQOOP-377
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Bilung Lee
> Assignee: Arvind Prabhakar
>
> Refer to SQOOP-371 for details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
