[ 
https://issues.apache.org/jira/browse/SQOOP-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138455#comment-13138455
 ] 

[email protected] commented on SQOOP-377:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2589/
-----------------------------------------------------------

(Updated 2011-10-28 15:38:03.522052)


Review request for Sqoop and Bilung Lee.


Changes
-------

Thanks for the review Bilung. Attaching the updated diff.


Summary
-------

Migrated the mapreduce.db package to org.apache.sqoop namespace.


This addresses bug SQOOP-377.
    https://issues.apache.org/jira/browse/SQOOP-377


Diffs (updated)
-----

  /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 
1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 
1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 
1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 
1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822 
  /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822 
  /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 
PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 
PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java 
PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 
PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 
PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION 
  /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822 
  /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822 
  /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION 
  /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2589/diff


Testing
-------

Ran all unit and thirdparty tests.


Thanks,

Arvind


                
> Migrate mapreduce.db package to new name space
> ----------------------------------------------
>
>                 Key: SQOOP-377
>                 URL: https://issues.apache.org/jira/browse/SQOOP-377
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Bilung Lee
>            Assignee: Arvind Prabhakar
>             Fix For: 1.4.0-incubating
>
>         Attachments: SQOOP-377-2.patch
>
>
> Refer to SQOOP-371 for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to