-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/#review4003
-----------------------------------------------------------


[Added this comment to the JIRA as well]

Eric, the OracleManager uses catalog queries for looking up metadata which 
requires case sensitive sepcification of user name and table name. If the 
user/table name was not quoted at the time of creation, Oracle by default 
converts them to upper case and hence you see this problem. It is also 
documented in the troubleshooting guide [1]. 

One way to alleviate this problem is to do modify Sqoop behavior so as to mimic 
Oracle's handling of such literals. In other words, if the specified user/table 
name is not quoted, Sqoop should convert them to upper case. If they are 
quoted, they should remain as specified. 

[1] 
http://incubator.apache.org/sqoop/docs/1.4.0-incubating/SqoopUserGuide.html#id1774574

- Arvind


On 2011-12-19 22:37:41, Eric Wadsworth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3266/
> -----------------------------------------------------------
> 
> (Updated 2011-12-19 22:37:41)
> 
> 
> Review request for Sqoop.
> 
> 
> Summary
> -------
> 
> Uppercase table name and table owner name
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/SQOOP-415.
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-415
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/manager/OracleManager.java 1220973 
> 
> Diff: https://reviews.apache.org/r/3266/diff
> 
> 
> Testing
> -------
> 
> Did not add any unit testing for this. Before the patch, sqoop fails for me 
> when connecting to oracle. When built with this patch, it works. "ant test" 
> passes.
> 
> 
> Thanks,
> 
> Eric
> 
>

Reply via email to