-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/
-----------------------------------------------------------

(Updated 2011-12-21 19:03:52.238073)


Review request for Sqoop.


Changes
-------

Removed the original patch I had submitted, and replaced it with a new one. 
This one checks for double-quotes around oracle table names and owner names, 
and uppercases them if they aren't quoted.


Summary (updated)
-------

Uppercase table name and table owner name if it's not surrounded by double 
quotes.


This addresses bug SQOOP-415.
    https://issues.apache.org/jira/browse/SQOOP-415


Diffs (updated)
-----

  /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1221519 
  /src/java/org/apache/sqoop/manager/OracleManager.java 1221519 

Diff: https://reviews.apache.org/r/3266/diff


Testing (updated)
-------

This patch includes a unit test. Before the patch, sqoop fails for me when 
connecting to oracle. When built with this patch, it works. "ant test" passes.


Thanks,

Eric

Reply via email to