On 01/20/2017 06:05 AM, FUSTE Emmanuel wrote: > We have to support many historic digest auth implementation for which > the realm is not included in the digest password attribute: > The password is effectively stored as "HA1" instead of "REALM:HA1". > I would like to kill our own homegrown helpers and use the Squid > provided one. > > Is something like the attached patch is acceptable/could be included > in a future Squid release ?
I would prefer that others answer your question because this is not my area of expertise, but if this patch is accepted, then please: 1. Rename notnulldelim to a positive name like haveDelimiter or, better, remove that variable completely in favor of a direct *delimiter test. 2. Use a *delimiter test instead of strcmp("") to detect empty delimiter strings. 3. Rephrase the -l help string to use "empty string" instead of "null" and "password alone" instead of "no realm" (or similar). Thank you, Alex. _______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev