> On Sat, 2008-02-23 at 14:35 +0100, Henrik Nordström wrote: > >> Please go to >> http://www.squid-cache.org/Versions/v3/HEAD/changesets/merge.html and >> inspect the list of patches to merge and not merge and give your opinion >> if you think some patch is should be given another priority or if there >> is an error in the grouping of related patches. > > The following patches are listed as "to be merged" (I think), but should > not be blindly merged until they are reviewed, polished, and committed. > > 11462 Bug #2230 possible fix: segmentation fault with a "pure > virtual method called" > > 11461 Bug #2224 fix: reentrant debugging crashes Squid > > 11387 Bug #2038: check reply_body_max_size before ICAP > 11388 Bug #2038: check reply_body_max_size before ICAP > 11389 Bug #2038: check reply_body_max_size before ICAP > > > The following patch is listed as "not to be merged", but probably should > be merged as it is a bug fix: > > 11360 Assert that checklist and request are set instead of > segfaulting as in bug 2168 > > > Thank you, > > Alex. > > >
Henrik: is there something special to do with individual patches not to be merged from a group of patches which as a whole are? The include directive group which I have just done had 3 in the middle which you may recall fixing-removing strtok_r usage. For now I have made them a seperate group not-merged and gone straight past to your strwordtok fix. Amos
