I have opened a bug for this issue here: http://bugs.squid-cache.org/show_bug.cgi?id=2788 Also, the previous patch was not generated against head so I re-rolled the patch against current head and attached to the bug report.
--Jason ----- Original Message ----- From: "Adrian Chadd" <adr...@squid-cache.org> To: "Jason Noble" <ja...@linuxbox.com> Cc: squid-dev@squid-cache.org Sent: Saturday, September 26, 2009 12:58:08 AM GMT -05:00 US/Canada Eastern Subject: Re: Segfault in HTCP CLR request on 64-bit Could you please create a bugzilla report for this, complete with a patch against Squid-2.HEAD and 2.7? I'll then commit it. 2009/9/26 Jason Noble <ja...@linuxbox.com>: > I recently ran into an issue where Squid 2.7 would segfault trying to issue > HTCP CLR requests. I found the segfault only occurred on 64-bit machines. > While debugging, I found that the value of stuff.S.req_hdrs was not > initialized but later, strlen was being called on it. This seems to -- by > chance -- not fail on 32 bit builds, but always segfaults on 64-bit. The > attached patch fixed the problem for me and it seems good programming > practice to properly initialize pointers to prevent issues such as this. As > the htcpStuff struct is used in other places, I have concerns that other > issues may be lurking as well, although I have yet to run into them. > > Regards, > Jason >
