On 06/10/2013 03:27 AM, Amos Jeffries wrote: > On 10/06/2013 8:35 a.m., Francesco Chemolli wrote: >> ------------------------------------------------------------ >> revno: 12903 >> committer: Francesco Chemolli <[email protected]> >> branch nick: trunk >> timestamp: Sun 2013-06-09 22:35:58 +0200 >> message: >> Instruct clang not to treat unused command line arguments as errors >> modified: >> acinclude/compiler-flags.m4 > > Anyone known why we have the "-Wno-error=parentheses-equality" option in > teh first place? > It would seem to me to be one of the warnings highlighting a coding > guideline violation we need to fix in the sources. Not something to be > suppressed.
I cannot find the description of that clang warning option, but if it focuses on extra parentheses in benign ((a == b)) cases, then it is a very minor problem not an important violation. And, as Kinkie pointed out, if it prevents us from righting (bool a = b), it should stay disabled even if it finds true problems like (a = b). We can rely on GCC to spot those true problems. Cheers, Alex.
