First a note for who is going to merge: the last commit doesn't have proper 
formatted commit message. So this PR should be squashed and merged or merged 
manually.

Then, I need a clarification: when this test is true: when all IPs in SDP match 
the source IP? If my logic is not missing something, the ip_addr_cmp() returns 
true if the two ips are the same, but you return -1 in that case.

Also, the result variable is set to 1 and used only for the return at the end. 
If you need it only for that, then remove it and just do return 1 at the end.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-525189583
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to