> As I looked at the entire diff -- do not change the formatting of existing
> code/docs files when adding a new features. Now the diff has a lot of changes
> in the xml doc files making hard to spot what was changed. Patches to fix
> existing indentation and whitespaces are more than welcome, but must be
> dedicated commits/pull requests. It can stay here, but have in mind for the
> future.
i dont change any indentation , vim can do it automatically. Sorry for it.
> I think further clarifications are needed, because there can be many c= lines
> in SDP and you return -1 with the first one when IPs matches, but maybe
> before or after that c= line it is a mismatch (e.g., audio session matches,
> video session mismatches). How should this be considered?
Well , i never see more c line so i didnt think about it. I will change it as
you mentioned.
> You can leave it like now, just explain in the docs.
>
> Or, an idea, you can add one (or two) variable(s) to count the c= lines that
> match (and those that mismatch). Then at the end of the function you test if
> matches is same value as the number of sessions and return different value if
> all matched, or there was some partial matches, or no matches.
>
> Also, I think there should be like return -2 (or other negative value) if SDP
> fails to be parsed, to be able to differentiate between error and match.
I will add more option but I hope it dont change other test results. For
example , if there is a problem parsing sdp return 2 from nat_uac_test()
function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-525251153
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
