@miconda commented on this pull request.
> @@ -1184,6 +1189,16 @@ static int build_iface_list(void)
nll = 0;
p = buf;
while(1) {
+ // This (and the loop above in get_flags) is
+ // broken in more than one aspect. For example,
+ // if a receive is shorter than nlmsghdr,
+ // nlp->nlmsg_type will point at garbage.
+ // Proper fix for this (and static buffer sizing
+ // problem) would be to use libnl.
This comment does not belong in the source code.
If there is still any issue left after this commit, then report it in the issue
tracker. The developers do not scan the code for comments pointing at possible
issues.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2595#pullrequestreview-561579800_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
