This caused no ill effects, since it wasn't used in the callback.
However, it is a layering violation (especially since req is freed
in the callback)
From 8581c46c5836e7eb355d9878f0b6829c59ee2852 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgall...@redhat.com>
Date: Thu, 28 Jul 2011 13:28:51 -0400
Subject: [PATCH] Remove incorrect private variable

This caused no ill effects, since it wasn't used in the callback.
However, it is a layering violation (especially since req is freed
in the callback)
---
 src/providers/ipa/ipa_dyndns.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/providers/ipa/ipa_dyndns.c b/src/providers/ipa/ipa_dyndns.c
index cdee518bde743015b957297cee3c4744cb03a87d..b75d135bd3210fd58b3849488de4a90c91ae2d00 100644
--- a/src/providers/ipa/ipa_dyndns.c
+++ b/src/providers/ipa/ipa_dyndns.c
@@ -70,7 +70,7 @@ void ipa_dyndns_update(void *pvt)
         DEBUG(1, ("Could not update DNS\n"));
         return;
     }
-    tevent_req_set_callback(req, ipa_dyndns_update_done, req);
+    tevent_req_set_callback(req, ipa_dyndns_update_done, NULL);
 }
 
 static void ipa_dyndns_sdap_connect_done(struct tevent_req *subreq);
-- 
1.7.6

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to