On (02/12/15 17:10), Michal Židek wrote: >Hi! > >I saw some integration tests failures recently, >and I think there is a race condition between the >enumeration refresh timeout and the sleeps >after some operations that wait for this timeout. >SSSD fails to populate changes from LDAP in time >and some asserts can fail because of this. > >So far I saw 4 tests to fail like this, which >is already quite a lot. > >The attached patch modifies the timeout values >and hopefully removes the issue. > >Michal
I think I found alternative solution for intermittent failures of ADD REMOVE test with enumeration. Occurence of failure was increased recently therefore please review attached patch. I know that Jakub wanted/tried to rewrite test without enumeration. But I was mentioned in this thread that testing on enumeration is valid case. LS
>From 7450ff8918e3763612ad256b8dc6152c438003d8 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Fri, 15 Apr 2016 22:46:21 +0200 Subject: [PATCH 1/3] intg: Reduce refresh timeout of enumeration task It caused some intermittent failures if entry_cache_timeout has the same value as ldap_enumeration_refresh_timeout. --- src/tests/intg/ldap_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tests/intg/ldap_test.py b/src/tests/intg/ldap_test.py index 757ee20a2884d1ba18804fb88b883e9bd23797e8..9774c290529b5eadf3a72c43c0ccc1b4643869f6 100644 --- a/src/tests/intg/ldap_test.py +++ b/src/tests/intg/ldap_test.py @@ -139,10 +139,10 @@ def format_interactive_conf(ldap_conn, schema): entry_negative_timeout = 0 [domain/LDAP] - ldap_enumeration_refresh_timeout = {0} + ldap_enumeration_refresh_timeout = {1} ldap_purge_cache_timeout = 1 entry_cache_timeout = {0} - """).format(INTERACTIVE_TIMEOUT) + """).format(INTERACTIVE_TIMEOUT, INTERACTIVE_TIMEOUT/2) def create_conf_file(contents): -- 2.7.3
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org