On Fri, Aug 05, 2016 at 02:49:59PM +0200, Petr Cech wrote: > On 08/04/2016 11:06 AM, Jakub Hrozek wrote: > > On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: > > > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pc...@redhat.com> wrote: > > > > Hello list, > > > > > > > > attached patch fixes duplication of pid file declaration. I hope that > > > > the > > > > util/util.h is the right place for it. Another opinion are welcome. > > > > > > LGTM! > > > > > > I'd wait till someone else reviews the patch, in case you want to be > > > sure that util/util.h is the right place for the defines. > > > > It is, but I don't think that MONITOR_NAME belongs there. I think the > > pidfile declaration can just use hardcoded sssd (or just #define > > PIDFILE_BASENAME to "sssd") and MONITOR_NAME should stay in monitor.c > > Right, thank you. Fixed patch attached :-)
ACK CI: http://sssd-ci.duckdns.org/logs/job/51/12/summary.html _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
