On (12/08/16 23:00), Lukas Slebodnik wrote: >On (12/08/16 16:41), Jakub Hrozek wrote: >>On Fri, Aug 12, 2016 at 02:38:44PM +0200, Lukas Slebodnik wrote: >>> On (12/08/16 14:13), Jakub Hrozek wrote: >>> >On Fri, Aug 12, 2016 at 01:47:04PM +0200, Lukas Slebodnik wrote: >>> >> On (12/08/16 07:39), Stephen Gallagher wrote: >>> >> >On 08/12/2016 07:30 AM, Lukas Slebodnik wrote: >>> >> >> On (12/08/16 13:24), Jakub Hrozek wrote: >>> >> >>> Hi, >>> >> >>> >>> >> >>> a simple one-liner is attached. >>> >> >> >>> >> >>>From c7bd0b7e695d031258ab47d8c425c9d5843d4069 Mon Sep 17 00:00:00 2001 >>> >> >>> From: Jakub Hrozek <jhro...@redhat.com> >>> >> >>> Date: Fri, 12 Aug 2016 13:23:16 +0200 >>> >> >>> Subject: [PATCH] CONFIG: full_name_format is an allowed option for >>> >> >>> all domains >>> >> >>> >>> >> >>> --- >>> >> >>> src/config/cfg_rules.ini | 1 + >>> >> >>> 1 file changed, 1 insertion(+) >>> >> >>> >>> >> >>> diff --git a/src/config/cfg_rules.ini b/src/config/cfg_rules.ini >>> >> >>> index >>> >> >>> 09f53fa41eb2904f11a78af333b6d79619d2759c..febe4289832f3778b7e974ef4e8b3f6d9d8bffd8 >>> >> >>> 100644 >>> >> >>> --- a/src/config/cfg_rules.ini >>> >> >>> +++ b/src/config/cfg_rules.ini >>> >> >>> @@ -287,6 +287,7 @@ option = subdomain_refresh_interval >>> >> >>> option = subdomain_inherit >>> >> >>> option = cached_auth_timeout >>> >> >>> option = wildcard_limit >>> >> >>> +option = full_name_format >>> >> >>> >>> >> >>> #Entry cache timeouts >>> >> >>> option = entry_cache_user_timeout >>> >> >> >>> >> >> Could you also update src/config/etc/sssd.api.* ? >>> >> >> >>> >> > >>> >> >Which will probably mean updating the SSSDConfigTest also. >>> >> > >>> >> I though it was implicit, becasue we reject patches which do not pass >>> >> unit+integration tests :-) >>> > >>> >Sure, see the attached patch. >>> >>> Thank you for a patch. >>> >>> I checked a source code and I noticed that we handle the option >>> re_expression >>> in the same way (in function sss_names_init_from_args) >>> >>> Would you mind to prepare patch for re_expression? >>> >>> BTW both otions are properly documented in sssd.conf >>> >> >>Sure, patches are attached. > >>From 27bdb80ecb62a9c7d62d745c7524aa236f257979 Mon Sep 17 00:00:00 2001 >>From: Jakub Hrozek <jhro...@redhat.com> >>Date: Fri, 12 Aug 2016 13:23:16 +0200 >>Subject: [PATCH 1/2] CONFIG: full_name_format is an allowed option for all >> domains >> >>--- >> src/config/SSSDConfig/__init__.py.in | 1 + >> src/config/SSSDConfigTest.py | 2 ++ >> src/config/cfg_rules.ini | 1 + >> src/config/etc/sssd.api.conf | 1 + >> 4 files changed, 5 insertions(+) >> >ACK > >>From 5c5e61e0baf3e9e984c1df3347e4178167edf583 Mon Sep 17 00:00:00 2001 >>From: Jakub Hrozek <jhro...@redhat.com> >>Date: Fri, 12 Aug 2016 16:41:21 +0200 >>Subject: [PATCH 2/2] CONFIG: re_expression is an allowed option for all >> domains >> >>--- >> src/config/SSSDConfig/__init__.py.in | 1 + >> src/config/SSSDConfigTest.py | 2 ++ >> src/config/cfg_rules.ini | 1 + >> src/config/etc/sssd.api.conf | 1 + >> 4 files changed, 5 insertions(+) >> >ACK > >http://sssd-ci.duckdns.org/logs/job/51/51/summary.html > master: * 6d19051c50c10fc4de056ebb385c63ec0ed221cb * cc4d1af16820b15595b60c3df15220fb852eb897
LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
