URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support
sumit-bose commented: """ Hi Lukas, thank you for your comments. I move get_pkinit_identity() out if the ifdef block. For pam_check_user_done() I removed the assignment which should hopefully silence the Coverity warning. Since we use pam_check_user_done() without assigning the return code to a variable at other places as well I hope you agree with this. I think we can even make pam_check_user_done() to return void but this should be handled by a different patch. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/137#issuecomment-280277210
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org