URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno
jhrozek commented: """ On Mon, Oct 08, 2018 at 01:56:37AM -0700, Tomáš Halman wrote: > @mzidek-rh, @jhrozek PR updated, I moved #define to sysdb.h. I also did the > cleanup. > > Please take a look at cleanup changes. Since I use sss_ldb_error_to_errno in > some places, modified functions can eventually return more error values. This looks mostly good. But one thing that I don't like very much is that krb5_child now needs to link with ldb libs. Do you think having util/util_ldb_errors.c to avoid this extra dependency is too excessive? > > For example old code: > https://github.com/SSSD/sssd/blob/dfa7bf1133f002a9fbbd3495a70909913db25b16/src/util/secrets/secrets.c#L419-L431 > > After my changes it can theoretically return also EFAULT. Right. But I think this is fine. I don't think any of the callers cared about any special error code other than EOK and maybe ENOENT. """ See the full comment at https://github.com/SSSD/sssd/pull/667#issuecomment-427953199
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
