URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces
sumit-bose commented: """ > > Thanks, @alexey-tikhonov, which solution would you prefer? > > If I understood correctly, your approach is to use the same DN string as a > table key everywhere instead of attempt to unify (transform to single state) > two DN strings (with help of trimming/sanitization). Hi, yes. > > If I got it right, then in general I like your approach more. > > But I must admit I don't understand sdap* code well enough to: > > * verify if you spotted all the places where this "new" attribute > (SYSDB_DN_FOR_MEMBER_HASH_TABLE) must be stored/updated and read to be used > as a key; Currently this is only about the ghost hash table where as far as I can see only when the entries were added the DN of the user object was used. Lookups are always done with the DN from the member attribute. So I think only the creation of the entries had to be updated. > > * to estimate performance hit (shouldn't be dramatic though, because it's > just one additional attr to store, and should have no impact during lookup; > but I can't compare performance-wise with Tomas' patch). Yes, this is always hard, but I agree, it is only about adding an additionally attribute, which would be a memory allocation and a copy of the string. Since there is no comparison for every single character it might be a bit faster than Tomas' patch but the trimming of spaces shouldn't take much time anyways. The main reason I propose this solution is that it would cover cases as well, e.g. when the DN in the member attribute differs in case from the DN of the user object. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-682354104
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
