URL: https://github.com/SSSD/sssd/pull/5712
Title: #5712: Health and Support Analyzer - Add request log parsing utility
sumit-bose commented:
"""
Hi Justin,
thanks for the latest updates.
I think the log lines from `accept_fd_handler` e.g.
2021-08-18 10:36:34:610384): [nss] [accept_fd_handler] (0x0400): Client
[CID #1][cmd su][0x55d181821070][27] connected!
or
(2021-08-18 10:36:34:703799): [pam] [accept_fd_handler] (0x0400): Client
[CID #1][cmd su][0x55bc092703c0][24] connected to privileged pipe!
are missing in the parser output, can you add it?
Can you show the help output if the command line is incomplete? Currently it
looks like:
```
# sssctl analyze
usage: sss_analyze [-h] [--source {files,journald}] [--logdir LOGDIR] {request}
...
sss_analyze: error: the following arguments are required: subcommand
Command '/usr/lib/python3.9/site-packages/sssd/sss_analyze.py' failed with [2]
# sssctl analyze request
#
```
The first case it should not be as an error but the help output should be shown
and since there is no `sss_analyze` which can be called it would be better to
say `sssctl analyze`. The second case currently has no output, help output
would be better here as well.
I would mention in the `--merge` help line that this currently only works
properly with `debug_microseconds = True` for all components.
Another item for improvement in a new pull-request is to add the tevent id
logic to the different responders. For the nss responder this won't change much
since the main task here is done in the cache request code. But e.g. for the
pam responder currently also only the cache request part of the logs is shown
by the parser but here there are other useful log messages from the main pam
responder code as well.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5712#issuecomment-901023962
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
