On Thu, 2011-05-26 at 19:55 +0200, Eric Dumazet wrote: > Le jeudi 26 mai 2011 à 12:47 -0500, Dan Williams a écrit : > > It's current exposed only through /proc which besides requiring > > screen-scraping doesn't allow userspace to distinguish between two > > identical ATM adapters with different ATM indexes. The ATM device index > > is required when using PPPoATM on a system with multiple ATM adapters. > > > > Signed-off-by: Dan Williams <[email protected]> > > --- > > > > PS: -> stable too since it's a minimal change with no backwards > > incompatibility and I'd like to rely on this attribute in NetworkManager > > > > diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c > > index f7fa67c..e5edbde 100644 > > --- a/net/atm/atm_sysfs.c > > +++ b/net/atm/atm_sysfs.c > > @@ -59,6 +59,16 @@ static ssize_t show_atmaddress(struct device *cdev, > > return pos - buf; > > } > > > > +static ssize_t show_atmindex(struct device *cdev, > > + struct device_attribute *attr, char *buf) > > +{ > > + char *pos = buf; > > + struct atm_dev *adev = to_atm_dev(cdev); > > + > > + pos += sprintf(pos, "%d\n", adev->number); > > + return pos - buf; > > +} > > + > > What about : > > { > struct atm_dev *adev = to_atm_dev(cdev); > > return sprintf(buf, "%d\n", adev->number); > }
Sure, will send v2. Dan _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
