On Oct 23, 2009, at 2:16 PM, Brion Vibber wrote:
I've got Meitar's redent-button branch merged and running on my test
site
[…]
I do notice a couple of issues though:
1) The original message is wrapped in quotes, which looks good and
is clear... but triggers a bug in our URL detection.
If the URL includes a path (even just "/") the final quote character
ends up included in the link, leading to link breakage.
This seems to me like a bug in the link detection regex. AFAIK,
quotation marks should never be a part of a URI because they should
always be embedded as '%22'.
So…is there a separate bug open for that? I couldn't find an open one
at http://status.net/bugs/ I'm not a regex sorcerer, but I can at
least take a look at it if it'll help this patch get accepted. (I
really, really want a repeat button in the web UI…it'll save so much
time.)
I conventionally quote anything that I "redent/retweet/repeat" that I
don't change. If I change it significantly, I usually remove the
quotes. This is why the quotes are there in the first place.
Do you think they should be removed when we press the repeat button?
2) The recycling character we're using as a repeat symbol looks
great in everything I've tried on my desktop Mac... but shows as a
big empty box on my iPhone, both on the web and in client apps like
Tweetie 2.
Has anybody tested other mobile devices for font compatibility with
this or other alternative chars?
I tested a few of the other recycling symbols, but (at least back when
I wrote the patch) they all frustratingly showed up as blank squares
on my iPod touch. I'm not sure what to do about that. :( Suggestions
are welcome.
Cheers,
-Meitar Moscovitz
Personal: http://maymay.net
Professional: http://MeitarMoscovitz.com
_______________________________________________
StatusNet-dev mailing list
[email protected]
http://lists.status.net/mailman/listinfo/statusnet-dev
