> On Oct 23, 2009, at 2:16 PM, Brion Vibber wrote: > >> I've got Meitar's redent-button branch merged and running on my test >> site >> [ ] >> I do notice a couple of issues though: >> >> 1) The original message is wrapped in quotes, which looks good and >> is clear... but triggers a bug in our URL detection. >> >> If the URL includes a path (even just "/") the final quote character >> ends up included in the link, leading to link breakage. > > This seems to me like a bug in the link detection regex. AFAIK, > quotation marks should never be a part of a URI because they should > always be embedded as '%22'. > > So is there a separate bug open for that? I couldn't find an open one > at http://status.net/bugs/ I'm not a regex sorcerer, but I can at > least take a look at it if it'll help this patch get accepted. (I > really, really want a repeat button in the web UI it'll save so much > time.)
According to the RFC, you're right: URLs cannot have " in them. But, unfortunately, in real life, people use "'s in URLs. For that reason, I allow them - but perhaps I should change that? ~Craig _______________________________________________ StatusNet-dev mailing list [email protected] http://lists.status.net/mailman/listinfo/statusnet-dev
