On Mon, Oct 10, 2011 at 7:10 PM, Bernhard Reutner-Fischer
<[email protected]> wrote:
> Hi,
>
> I'm resending a previous suggestion from one or two years ago to add
> support for loading and unloading plugins without the need to restart
> stellarium:
>
> https://code.launchpad.net/~rep-dot-nop/stellarium/http_proxy
>
> That branch currently contains approximately:
>
> - fix typo
>            s/centre/center
> - Fix setting proxy without username/password
>            Simplify password obfuscation while at it.
> - add life (un)loading of plugins
>            As an example, convert Ocular to be unloadable
>
>
> Comments?

A few brief comments, as I'm rather tired (6+ hours in a train today).
There may be more later.
- I think that the plug-in module loading/unloading code should be in
ModuleMgr, not in a GUI class
- I prefer "enable"/"disable" to "load"/"unload"
- "center"/"centre" is not a typo, but a difference between American
and British variants of English. I'm not sure what is the preferred
variant to use in Stellarium's interface. In all cases, changing it in
the code comments is overkill. :)

Regards,
Bogdan Marinov

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
Stellarium-pubdevel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel

Reply via email to