On Tue, Oct 11, 2011 at 12:11 AM, Bernhard Reutner-Fischer <[email protected]> wrote: > > On Oct 10, 2011 9:32 PM, "Bogdan Marinov" <[email protected]> wrote: >> >> On Mon, Oct 10, 2011 at 7:10 PM, Bernhard Reutner-Fischer >> <[email protected]> wrote: >> > Hi, >> > >> > I'm resending a previous suggestion from one or two years ago to add >> > support for loading and unloading plugins without the need to restart >> > stellarium: >> > >> > https://code.launchpad.net/~rep-dot-nop/stellarium/http_proxy >> > >> > That branch currently contains approximately: >> > >> > - fix typo >> > s/centre/center >> > - Fix setting proxy without username/password >> > Simplify password obfuscation while at it. >> > - add life (un)loading of plugins >> > As an example, convert Ocular to be unloadable >> > >> > >> > Comments? >> >> A few brief comments, as I'm rather tired (6+ hours in a train today). >> There may be more later. >> - I think that the plug-in module loading/unloading code should be in >> ModuleMgr, not in a GUI class > > The loading/unloading is in modulemgr. > Just the button handling is in a GUI class, just like adding a button is :)
I was talking about the code in the Configuration window class, but never mind - on a second look, it's not a problem. I must really have been tired. >> - I prefer "enable"/"disable" to "load"/"unload" > > Well, the checkbox talks about "load at startup" so loading seemed natural, > of course we could rename it. I think "enable"/"disable" is clearer to the users, but I'm open for other suggestions. The original word choice was not very good either. I'm afraid that the fix on the bug I'm working on will interfere with your code: https://bugs.launchpad.net/stellarium/+bug/807402 I'm going to commit it to the trunk, so you'll have to merge it in. You can also do without the StelModuleMgr::getIdForName() function: I think that you can store plug-in IDs as Qt::UserRole data in the elements of the list, as I've done here: http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/4949 to fix this bug: https://bugs.launchpad.net/stellarium/+bug/834886 It's a convenient way of handling IDs and display names in the same place. Regards, Bogdan Marinov ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Stellarium-pubdevel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
