2009/10/5 Dmitry V. Levin <l...@altlinux.org>:
>> - tcp->u_nargs = MAX_ARGS;
>> + /* Unknown syscall, assume maximum number of
>> arguments. */
>> + tcp->u_nargs = sizeof(args)/sizeof(args[0]);
>> for (i = 0; i < tcp->u_nargs; i++) {
>> - if (upeek(tcp, PT_GR26-4*i, &tcp->u_arg[i]) < 0)
>> + if (upeek(tcp, args[i], &tcp->u_arg[i]) < 0)
>> return -1;
>> }
>> }
>
> This hunk does not look correct.
> If MAX_ARGS should be lowered on HPPA from 32 to 6, let's change it in
> the defs.h file.
Dmitry,
Lowering HPPA from 32 to 6 syscall args is correct.
Thank you for committing the hppa fixes listed below.
I have verified that upstream strace HEAD works correctly on hppa.
~~~
commit 67874d8393499e3c7f0d5a950f2707758560f61f
Author: Dmitry V. Levin <l...@altlinux.org>
Date: Mon Oct 5 23:32:39 2009 +0000
* defs.h [HPPA]: Lower MAX_ARGS from 32 to 6.
commit c0124e64489277d2d8a6c76ee66579ffa18e052e
Author: Dmitry V. Levin <l...@altlinux.org>
Date: Mon Oct 5 23:31:54 2009 +0000
* ipc.c [LINUX] (sys_shmat): HPPA does not use an IPC multiplexer.
Based on patch from Carlos O'Donell.
commit 1dc2061c2ac7a73fa3d88fa0b10079151f7de530
Author: Carlos O'Donell <car...@systemhalted.org>
Date: Mon Sep 14 02:06:20 2009 +0000
* linux/hppa/syscallent.h: Update syscalls.
Based on work by Kyle McMartin and Helge Deller.
commit 4677c8af94bcb3f39d5bf929ee44cd6724b7d0b8
Author: Carlos O'Donell <car...@systemhalted.org>
Date: Wed Sep 9 18:13:19 2009 +0000
Fix SA_HANDLER function pointer comparisons for hppa
* signal.c (sys_sigaction): Cast SA_HANDLER function pointers to long.
(sys_rt_sigaction): Likewise.
~~~
Cheers,
Carlos.
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel
