On Tue, Oct 06, 2009 at 06:05:32PM -0700, Roland McGrath wrote: > I committed some nits to make for a happy make distcheck (d087571). After > that, everything looks good to me.
I noticed a compilation warning on x86: util.c: In function 'do_ptrace': util.c:260: warning: passing argument 4 of 'ptrace' makes integer from pointer without a cast defs.h:163: note: expected 'long int' but argument is of type 'void *' util.c: In function 'ptrace_restart': util.c:282: warning: passing argument 4 of 'ptrace' makes integer from pointer without a cast defs.h:163: note: expected 'long int' but argument is of type 'void *' Mike Frysinger already submitted a fix for this issue, I'm going to check it on x86 and x86-64, and merge it if everything is OK. Another small issue is file timestamps in release tarball. Since git does not store timestamps, all files will have current mtime after checkout, while we still package files with last modification in previous century (e.g. PORTING). There is a script, git-set-file-times, which could be called right after checkout to set mtime and atime of files to their latest commit time in git: http://gitweb.samba.org/?p=rsync.git;a=blob_plain;f=support/git-set-file-times I suggest to use it for preparing release tarball. -- ldv
pgp5Y9zYkJNNa.pgp
Description: PGP signature
------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
