Add "event" for subclasses of OnwardResolution
----------------------------------------------
Key: STS-785
URL: http://www.stripesframework.org/jira/browse/STS-785
Project: Stripes
Issue Type: Improvement
Affects Versions: Release 1.5.4
Reporter: Nikolaos
Priority: Trivial
When attempting to create things like LocalizedRedirectResolution one
subclasses RedirectResolution
However in: net.sourceforge.stripes.action.OnwardResolution
We have:
private static final String VALUE_NOT_SET = "VALUE_NOT_SET";
private String path;
private String event = VALUE_NOT_SET;
private Map<String,Object> parameters = new HashMap<String,Object>();
private String anchor;
Problem #1:
----------------
path, anchor, and parameters have public getters/setters however 'event'
attribute does not?
REQUEST: Please add public getters/setters for event
NOTE: One could make the above things protected to be accessible in subclasses
but I suggest public as it is in-line with how the rest of the class is written.
Problem #2:
----------------
Having public access to to 'event' is great but one needs to be able to compare
to see if the value is not set however the following is private:
private static final String VALUE_NOT_SET = "VALUE_NOT_SET";
REQUEST: Please make the above static at least protected vs. private so as to
be able to compare within subclasses.
This is a really trivial request that makes the class more consistent.
--Nikolaos
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
