[
http://www.stripesframework.org/jira/browse/STS-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Gunter resolved STS-785.
----------------------------
Resolution: Fixed
Fix Version/s: Release 1.6
Assignee: Ben Gunter
> Add "event" for subclasses of OnwardResolution
> ----------------------------------------------
>
> Key: STS-785
> URL: http://www.stripesframework.org/jira/browse/STS-785
> Project: Stripes
> Issue Type: Improvement
> Affects Versions: Release 1.5.4
> Reporter: Nikolaos
> Assignee: Ben Gunter
> Priority: Trivial
> Fix For: Release 1.5.7, Release 1.6
>
> Attachments:
> 0001-Fixed-Issue-5-STS-785-Add-event-for-subclasses-of-On.patch,
> publicEventGetterAndProtectedEventConstant.patch
>
>
> When attempting to create things like LocalizedRedirectResolution one
> subclasses RedirectResolution
> However in: net.sourceforge.stripes.action.OnwardResolution
> We have:
> private static final String VALUE_NOT_SET = "VALUE_NOT_SET";
> private String path;
> private String event = VALUE_NOT_SET;
> private Map<String,Object> parameters = new HashMap<String,Object>();
> private String anchor;
> Problem #1:
> ----------------
> path, anchor, and parameters have public getters/setters however 'event'
> attribute does not?
> REQUEST: Please add public getters/setters for event
> NOTE: One could make the above things protected to be accessible in
> subclasses but I suggest public as it is in-line with how the rest of the
> class is written.
> Problem #2:
> ----------------
> Having public access to to 'event' is great but one needs to be able to
> compare to see if the value is not set however the following is private:
> private static final String VALUE_NOT_SET = "VALUE_NOT_SET";
> REQUEST: Please make the above static at least protected vs. private so as
> to be able to compare within subclasses.
> This is a really trivial request that makes the class more consistent.
> --Nikolaos
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
