Hi Stripes users. I've checking out the REST support in Stripes. I see that there are some things missing or to improve:
- REST support uses naming patterns which is discouraged because typographical errors may result in silent failures and other points described by Bloch ( http://jtechies.blogspot.pe/2012/07/item-35-prefer-annotations-to-naming.html). Now we have annotations. Look at JUnit, they are no more using naming patterns to test classes, they have @Test. Naming patterns seems like we're back in Java 1.4. Please let's use @POST, @GET, @DELETE,etc. - - REST support by default, and with no chance for further customization, packages up all the validation errors in a defined way. It will be better if we leave the developer free to change it respecting ValidationErrorHandler. Look line 357 of DispatcherHelper. - - REST support doesn't have an expressive way to return headers or error codes. It will be nice if we create a class called HttpResolution which can send headers, error codes, check ResponseEntity of Spring MVC or DefaultHttpHeaders of Struts2. - - We need an enumeration for status codes something like HttpStatus of Spring MVC: https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/http/HttpStatus.html - - The new class JsonResolution is tightly coupled with Jackson because JsonBuilder uses Jackson directly. What if need Gson? We need a JsonBuilderFactory there. - - Last, the new class HttpRequestMethod can be better called HttpMethod, is more shorter. Thanks!
------------------------------------------------------------------------------
_______________________________________________ Stripes-users mailing list Stripes-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/stripes-users
