Bringing this discussion of latest SAIF changes over to the struts-apps mailing list....
On Thu, 27 Nov 2003, Lars Hoss wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Well I try to do my best :-) > > 1. Changed method signature of ActionInterceptor.doIntercept so that it > know returns ActionForward > instead of void. > > 2. The processing of real Struts action is now longer handled by the > RequestHelper but ActionInterceptorChainImpl. > This is necessary in order to realize an AroundInterceptor. > > 3. You can now define properties inside the interceptor definition in > interceptor-config.xml. Are you using separate elements for that? What about taking all unknown interceptor element attributes and setting those? > 4. Wildcard support Nice, should help cut down config. Is it easy/possible for a user to plug in their own class for selecting actions? > 5. Generall cleanups > > I think it would be a very good idea to make use of a Mailinglist? > Perhaps we should use the SourceForge tools > a bit more? Do you have any experience with them? I'd say this list is a good start :) > > Yours, > Lars > > > Am 26.11.2003 um 22:21 schrieb Don Brown: > > > Sorry I haven't been following this too closely, but could you make a > > simple list of what changes this patch makes, particularly focusing on > > new/changed functionality? I'm glad to see you working hard on it and > > don't want to let this slip through the cracks. Thanks. > > > > Don > > > > On Mon, 24 Nov 2003 [EMAIL PROTECTED] wrote: > > > >> > >>> On fr 21.11.2003 17:22 Chr said: > >>> [stop press: I see now that this will still not work for wildcards. > >>> I will > >> have a closer look at it on monday] > >> > >> Attached is a new version of RequestProcessorHelper that restores the > >> functionality for RequestProcessorHelper.getAction(). > >> > >> The old code (quite correctly) presupposed that the ActionElement > >> instance > >> could be retrieved from InterceptorConfig.getActionElement() directly > >> via > >> the action class name. > >> > >> Now that we have added support for paths and wildcards in > >> ActionElement.getType() this is no longer the case. > >> > >> I have added a getTypeForAction(mapping) method to > >> RequestProcessorHelper > >> that will return the value of ActionElement.getType() for any request > >> that > >> is configured for interception. > >> > >> I believe the code now works as intended, please let me know if this > >> is not > >> the case. > >> > >> Oh... and about the IoC comment in your last mail: > >> > >>> Don has already developed a plugin which integrates > >>> Spring into Struts. Perhaps we should > >>> look if we can bring SAIF and his work together? > >> > >> Yep. We use Apache Avalon for our IoC stuff. It would be nice if SAIF > >> defined a IoC container adapter interface that made it easy to write > >> plugins > >> that supports the common set of features of the most popular IoC > >> containers. > >> Pico, Spring, Avalon etc. > >> > >> Could you let me know if you are planning to add my changes to cvs or > >> not? I > >> don't want to be pushy, but we need the interceptor stuff for our > >> current > >> project, and I need to know wether I should branch off of SAIF or keep > >> sending patches to you... > >> > >> CHR > >> > >> > >> > >>> -----Original Message----- > >>> From: Lars Hoss [mailto:[EMAIL PROTECTED] > >>> Sent: 20. november 2003 23:27 > >>> To: [EMAIL PROTECTED] > >>> Subject: Re: [SAIF] Proposed patches for RequestProcessorHelper and > >>> Interc eptorConfig > >>> > >>> > >>> -----BEGIN PGP SIGNED MESSAGE----- > >>> Hash: SHA1 > >>> > >>> Hi! > >>> > >>> It seems that you have removed the scoping stuff? Scoping > >>> allows you to > >>> define if an Action instance should be > >>> created per request, per session or per application. We had > >>> many users > >>> requesting this feature. By default Struts > >>> only knows the application scope. Don has added this feature > >>> some days > >>> ago. I will merge his code and yours > >>> together. > >>> > >>>> I'll see if I can make an implementation of this that does > >>> not impair > >>>> performance to much. > >>> > >>> Yup, that's a point. But the user can choose to use regexp or not. > >>> Concerning performance it would be good if > >>> the processor could find out wether to use regexp or not. > >>> > >>>> Nope... but I would not be above some cannibalization of > >>> their stuff if > >>>> there is something usefull there for SAIF. Any WW2 features > >>> you'd like > >>>> to > >>>> see implemented? > >>> > >>> Personally I really like this OGNL stuff. But this is another point. > >>> What I really would like to see is a good integration of a > >>> lightweight > >>> container for services such as Spring. > >>> Struts focus is on the presentation tier and this is ok. But > >>> typically > >>> an applications requires some > >>> service/component support as well. If you don't wan't to use EJB > >>> something like Spring or PicoContainer > >>> might be usefull. I wonder if we can bring those two world > >>> together in > >>> order to ease the development of > >>> applications. Don has already developed a plugin which integrates > >>> Spring into Struts. Perhaps we should > >>> look if we can bring SAIF and his work together? > >>> > >>>> Sounds cool. Only negative thing i see is the new library > >>> dependency. > >>>> This > >>>> always creates the potential for Jarmageddon if the library is also > >>>> present > >>>> elswere in the container classloader hierarchy. > >>> > >>> Yeah, I know what you mean. Sometimes the JAR hell can make you going > >>> crazy. > >>> Fortunately only SAIFActionServlet requires Javassist and if > >>> you do not > >>> want to use > >>> the "dynamic RequestProcessor patching stuff" you simply can use the > >>> old integration method. > >>> > >>> Yours, > >>> Lars > >>> > >>> - --- > >>> AcidWare.net - Better Software For Your Mac > >>> www: http://www.acidware.net > >>> email: [EMAIL PROTECTED] > >>> > >>> > >>> -----BEGIN PGP SIGNATURE----- > >>> Version: PGP 8.0.3 > >>> > >>> iQA/AwUBP70/p7cyzbDWnRDCEQL/VwCgzKKCcUCJ6mCnKOfEEomrZnuzNnsAoPLa > >>> wSC5fQMZWX5kYI35t5lU9POB > >>> =Hajf > >>> -----END PGP SIGNATURE----- > >>> > >> > >> > > > > -----BEGIN PGP SIGNATURE----- > Version: PGP 8.0.3 > > iQA/AwUBP8U4/bcyzbDWnRDCEQIk/wCgq1vhIO/w9x20cwSLs4bMI566i9sAoODn > jwEwZ4rY22zS0VSFGh8UZrGR > =qS4b > -----END PGP SIGNATURE----- > > ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Struts-apps mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/struts-apps
