HAHAHA......guess what?  I'm wrong, sorry.

When I read the commit....I was seeing this:

 @@ -218,8 +219,7 @@
               synchronized (messages) {
                   message = (String) messages.get(messageKey);
                   if (message != null) {
  -                    if (addIt)
  -                        messages.put(originalKey, message);
                       return (message);
                   }
               }

...and that's not what is actually there.

I was trying to figure out why you were omitting:

         messages.put(originalKey, message);

so, after writing a small white paper on what the method was doing and
why....I realized that I must have been cross-eyed when I read it.

I hope you can forgive me?????



James Mitchell
Software Engineer/Struts Evangelist
http://www.open-tools.org




> -----Original Message-----
> From: Robert Leland [mailto:rleland@;apache.org]
> Sent: Thursday, October 17, 2002 2:13 PM
> To: Struts Developers List
> Subject: Re: cvs commit: jakarta-struts/src/share/org/apache/struts/util
> PropertyMessageResources.java
>
>
>  > That correct, they need to be there as well.
> James, this is getting to be alot of work, you must
> be bucking for comitter :-D !
>
> Under what circumstances will addIt after the while loop
> be false ? I'll buy you a copy of Teds Book if
> you can provide just one case. If you can't then you'll
> own nothing except to keep being curious.
> I am serious about that offer !!!
>
> -Rob
>
>
> --
> To unsubscribe, e-mail:
> <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:struts-dev-help@;jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>

Reply via email to