On Sun, 9 Mar 2003, James Mitchell wrote:
> Date: Sun, 9 Mar 2003 11:24:49 -0500 > From: James Mitchell <[EMAIL PROTECTED]> > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > To: 'Struts Developers List' <[EMAIL PROTECTED]> > Subject: RE: Running Cactus Tests > > My final take on this (as stated in committed change to > jspRedirector.jsp): > > Modified: web/test jspRedirector.jsp > Log: > Update redirector to a version that (at least) compiles with > Cactus 1.3, 1.4, and 1.4.1 > > I still cannot make any tests pass that call request.getServerPort() > in the > Cactus 1.4.x environment. This may be a known bug with that project > or perhaps a mismatch of dependent jars. > > For now, our tests will only run on Cactus 1.3 > > > Unless I'm blindly missing some configuration, there appears to be > something wrong with Cactus' implementation of HttpServletRequest in > 1.4.x versions. Calling request.getServerPort() always returns 80. > > I would appreciate someone else with more Cactus expertise to take a > look at what I might be missing. > Which test(s) fail for you? The changes to jspRedirector.jsp made many of the tests work for me -- but I get an error on test suite org.apache.struts.taglib.html.TestErrorsTag1, in the "testErrorsDefaultBundle2Errors" testcase (the second one executed). The failure is comparing the expected and test results, and looks like it might just be a newline inserted in one but not the other -- but this doesn't appear related to getServerPort(). > > -- > James Mitchell > Software Developer/Struts Evangelist > http://jakarta.apache.org/struts > Craig > "People demand freedom of speech to make up for the freedom of thought > which they avoid." > - Soren Aabye Kierkegaard (1813-1855) > > > > > > -----Original Message----- > > From: James Mitchell [mailto:[EMAIL PROTECTED] > > Sent: Saturday, March 08, 2003 7:29 PM > > To: 'Struts Developers List' > > Subject: RE: Running Cactus Tests > > > > > > Sorry for not responding sooner, kids had soccer games today. > > > > Found this: > > > > > > http://www.mail-archive.com/[EMAIL PROTECTED]/msg0 > > 0901.html > > > > Looks like all we need to do is replace the /test/jspRedirector.jsp. > > > > For some odd reason, after changing to a newer redirector, a few tests > > are failing (which never happens.......I swear ;) I'm still looking > > into it, but this should be pretty staightforward. > > > > > > > > -- > > James Mitchell > > Software Developer/Struts Evangelist > > http://jakarta.apache.org/struts > > > > "People demand freedom of speech to make up for the freedom of thought > > which they avoid." > > - Soren Aabye Kierkegaard (1813-1855) > > > > > > > > > -----Original Message----- > > > From: Craig R. McClanahan [mailto:[EMAIL PROTECTED] > > > Sent: Saturday, March 08, 2003 3:22 PM > > > To: Struts Developers List > > > Subject: RE: Running Cactus Tests > > > > > > > > > > > > > > > On Sat, 8 Mar 2003, James Mitchell wrote: > > > > > > > Date: Sat, 8 Mar 2003 14:57:26 -0500 > > > > From: James Mitchell <[EMAIL PROTECTED]> > > > > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > > > > To: 'Struts Developers List' <[EMAIL PROTECTED]> > > > > Subject: RE: Running Cactus Tests > > > > > > > > Should we switch the test environment to 1.4.1? > > > > > > > > > > How much work would it be? I'd rather not totally disrupt > > > moving towards > > > 1.1 if it's a bunch. > > > > > > Craig > > > > > > > -- > > > > James Mitchell > > > > Software Developer/Struts Evangelist > > > > http://jakarta.apache.org/struts > > > > > > > > "People demand freedom of speech to make up for the freedom > > > of thought > > > > which they avoid." > > > > - Soren Aabye Kierkegaard (1813-1855) > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: James Mitchell [mailto:[EMAIL PROTECTED] > > > > > Sent: Saturday, March 08, 2003 2:53 PM > > > > > To: 'Struts Developers List' > > > > > Subject: RE: Running Cactus Tests > > > > > > > > > > > > > > > Yep, as I suspected, they moved to commons logging in 1.4. > > > > > > > > > > -- > > > > > James Mitchell > > > > > Software Developer/Struts Evangelist > > > > > http://jakarta.apache.org/struts > > > > > > > > > > "People demand freedom of speech to make up for the > > > freedom of thought > > > > > which they avoid." > > > > > - Soren Aabye Kierkegaard (1813-1855) > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: James Mitchell [mailto:[EMAIL PROTECTED] > > > > > > Sent: Saturday, March 08, 2003 2:48 PM > > > > > > To: 'Struts Developers List' > > > > > > Subject: RE: Running Cactus Tests > > > > > > > > > > > > > > > > > > I just checked the jars and there are several files missing > > > > > (including > > > > > > the one you mention) from 1.3 to 1.4, I'll have to > > > > > investigate further > > > > > > to see why. > > > > > > > > > > > > > > > > > > -- > > > > > > James Mitchell > > > > > > Software Developer/Struts Evangelist > > > > > > http://jakarta.apache.org/struts > > > > > > > > > > > > "People demand freedom of speech to make up for the freedom > > > > > of thought > > > > > > which they avoid." > > > > > > - Soren Aabye Kierkegaard (1813-1855) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Craig R. McClanahan [mailto:[EMAIL PROTECTED] > > > > > > > Sent: Saturday, March 08, 2003 2:42 PM > > > > > > > To: Struts Developers List > > > > > > > Subject: RE: Running Cactus Tests > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sat, 8 Mar 2003, James Mitchell wrote: > > > > > > > > > > > > > > > Date: Sat, 8 Mar 2003 14:36:55 -0500 > > > > > > > > From: James Mitchell <[EMAIL PROTECTED]> > > > > > > > > Reply-To: Struts Developers List > > > <[EMAIL PROTECTED]> > > > > > > > > To: 'Struts Developers List' > > <[EMAIL PROTECTED]> > > > > > > > > Subject: RE: Running Cactus Tests > > > > > > > > > > > > > > > > I was using jakarta-cactus-13-1.3, should I switch? > > > > > > > > > > > > > > > > > > > > > > It might be worth a try to see if it's really a version > > > > > > > incompatibility > > > > > > > with Cactus 1.3 versus 1.4, or just something > > messed up in my > > > > > > > environment. > > > > > > > Our build-tests.xml file says it should work with Cactus > > > > > 1.3+, so in > > > > > > > principle it should work with either. But my first goal is > > > > > > to get the > > > > > > > tests to run at all :-). > > > > > > > > > > > > > > Craig > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: > > > [EMAIL PROTECTED] > > > > > > > For additional commands, e-mail: > > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: > > > [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: > > [EMAIL PROTECTED] > > > > > For additional commands, e-mail: > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
