Only that unnecessary calls to the URLEncoder.encode within the computeURL method adds excess overhead that is not always needed. If encoding a url could be optionally turned on / off, performance would be better. The URLEncoder instantiates a ByteArrayOutputStream and a BufferedWriter which can add significant process cycles when called repetitively.
Also, any routines that allocate memory buffers like the URLEncoder or MessageFormat should be questioned for performance. They add significant overhead over time on highly repetitive calls. Also, if a machine begins to run low on memory, the constant allocation and release of these buffers only makes the situation worse. -----Original Message----- From: James Mitchell [mailto:[EMAIL PROTECTED] Sent: Monday, March 10, 2003 10:01 AM To: Struts Developers List Subject: RequestUtils.computeURL() Is there any reason that any tag should NOT call computeURL when evaluating a URL that needs a parameter of Map entries added? It seems that ImgTag does it all by itself, and since it hard-codes '&' instead of the standard '&', my new tests (which I haven't even committed yet) are failing. Should we refactor this now? I cannot setup tests for this tag with the current code that's there. Thoughts? -- James Mitchell Software Developer/Struts Evangelist http://jakarta.apache.org/struts "People demand freedom of speech to make up for the freedom of thought which they avoid." - Soren Aabye Kierkegaard (1813-1855) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
