[
https://issues.apache.org/jira/browse/SUBMARINE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843331#comment-16843331
]
Hadoop QA commented on SUBMARINE-49:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
26s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed.
{color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
24s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color}
|
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 53s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
40s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
24s{color} | {color:red} hadoop-submarine-yarnservice-runtime in trunk failed.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
22s{color} | {color:red} hadoop-submarine-tony-runtime in trunk failed. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 14s{color} | {color:orange} hadoop-submarine: The patch generated 9 new + 25
unchanged - 14 fixed = 34 total (was 39) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 27s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 52s{color}
| {color:red} hadoop-submarine-core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 56s{color}
| {color:red} hadoop-submarine-yarnservice-runtime in the patch failed. {color}
|
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hadoop-submarine-tony-runtime in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 63m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.submarine.client.cli.param.runjob.TestQuickLinks |
| |
hadoop.yarn.submarine.client.cli.runjob.tensorflow.TestRunJobParametersTensorFlow
|
| | hadoop.yarn.submarine.client.cli.param.runjob.TestTensorBoardParameters |
| | hadoop.yarn.submarine.client.cli.param.runjob.TestRoleParameters |
| | hadoop.yarn.submarine.client.cli.param.runjob.TestLocalizations |
| | hadoop.yarn.submarine.runtimes.yarnservice.pytorch.TestPyTorchServiceSpec
|
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/Dockerfile
|
| JIRA Issue | SUBMARINE-49 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12968798/SUBMARINE-49.006.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 77bc760843cd 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec
10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 732133c |
| Default Java | 1.8.0_212 |
| mvnsite |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/branch-mvnsite-hadoop-submarine_hadoop-submarine-tony-runtime.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/branch-findbugs-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/branch-findbugs-hadoop-submarine_hadoop-submarine-tony-runtime.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/diff-checkstyle-hadoop-submarine.txt
|
| unit |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-core.txt
|
| unit |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/artifact/out/patch-unit-hadoop-submarine_hadoop-submarine-yarnservice-runtime.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/testReport/ |
| Max. process+thread count | 304 (vs. ulimit of 10000) |
| modules | C: hadoop-submarine/hadoop-submarine-core
hadoop-submarine/hadoop-submarine-yarnservice-runtime
hadoop-submarine/hadoop-submarine-tony-runtime U: hadoop-submarine |
| Console output |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/130/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
> Add more test coverage to RunJobParameters
> ------------------------------------------
>
> Key: SUBMARINE-49
> URL: https://issues.apache.org/jira/browse/SUBMARINE-49
> Project: Hadoop Submarine
> Issue Type: Sub-task
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: SUBMARINE-49.001.patch, SUBMARINE-49.002.patch,
> SUBMARINE-49.003.patch, SUBMARINE-49.004.patch, SUBMARINE-49.004.patch,
> SUBMARINE-49.005.patch, SUBMARINE-49.006.patch
>
>
> There are some good tests in
> {{org.apache.hadoop.yarn.submarine.client.cli.TestRunJobCliParsing}}, but
> these are not testing all fields set by method
> {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}.
>
> Some more extensive testing is needed in this area.
> As an added bonus, the code
> {{org.apache.hadoop.yarn.submarine.client.cli.param.RunJobParameters#updateParametersByParsedCommandline}}
> could be cleaned up a bit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
