On Fri, 2014-04-11 at 08:34 +0530, Venkatesh Shukla wrote: > +static void parse_settings_userid(char *line, struct > membuffer *str, > void *_unused) > +{ > + char *uid = line; > + if (uid) > + { > + set_save_userid_local(true); > + set_userid(uid); > + } > +} > > Why do you have that local variable "uid"? Wouldn't it be much > easier to > just use "line"?
careful... this is not what I meant: +static void parse_settings_userid(char *line, struct membuffer *str, void *_unused) +{ + set_save_userid_local(true); + set_userid(line); +} + Notice the difference? > As you have hinted, there might be more problems in this patch. Please > do mention them so that I can improve both the patch and myself. > Eagerly waiting for your feedbacks. I didn't see anything else staring out at me. Would anyone else be so kind to take a look, please? My brain is pretty much flat lining... /D _______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface