On Wed, Aug 13, 2014 at 08:52:16PM -0700, Thiago Macieira wrote: > On Wednesday 13 August 2014 21:10:31 Dirk Hohndel wrote: > > > Note that this needs libdivecomputer with at least commit > > > 56e2dec7266e71e725604a4a8bff5e61f3d62259 (I've cherry-picked that to > > > release-0.4 and it built successfully). > > > > Does it need that to BUILD or to WORK? > > Build. Without it, you're going to get undefined references to hw_ostc3_* > functions.
I would have VERY MUCH appreciated if you had included a #define on the libdivecomputer side that had would have allowed us to build this conditionally on the Subsurface side. We're right after the release so this isn't as big of a deal because we can talk to Jef to do a 0.5 release of libdivecomputer before we release 4.3 - but in general I dislike API changes in a library that I cannot conditionally compile for. > The "work" part is something we'd appreciate feedback on :-) Do you want me to pull this into master now, or do you assume people will test by pulling from your repository? /D _______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface