On Thu, Aug 14, 2014 at 04:26:11PM +0200, Jef Driesen wrote: > >I would have VERY MUCH appreciated if you had included a #define on the > >libdivecomputer side that had would have allowed us to build this > >conditionally on the Subsurface side. > > You can conditionally build on the DC_VERSION_CHECK(0,5,0) macro. That would > only break if you checkout a much older commit on the master branch. But why > would anyone want do that? The master branch is an unstable development > branch for a reason. But as promised I'm not planning any backwards > incompatible changes (from v0.4.x) until v0.5 is released.
Good point. I built the Windows and Mac binaries with top of master because it added quite a few fixes over what was in the 0.4 branch. And we can add a note in the README file when I pull this code that from now on we require 0.5-devel or newer, including that specific commit. > New functions can't break backwards compatibility, because they didn't exist > before. But if you start to use them, that of course means you now have a > dependency on v0.5 and not v0.4! Yes. > >We're right after the release so this isn't as big of a deal because we > >can talk to Jef to do a 0.5 release of libdivecomputer before we release > >4.3 - but in general I dislike API changes in a library that I cannot > >conditionally compile for. > > I plan to release v0.5 in the not too distant future. Probably the end of > September. So it will be out long before 4.3. Perfect. Thanks /D _______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
