On Sat, Feb 07, 2015 at 08:10:36AM -0800, Dirk Hohndel wrote: > > What about old logs? We could delete all those pO2 values if the dive > > computer is a Predator and the user selects OC as dive mode? > > I have a draft patch that does that but wanted to talk to you about it. > This is a non-reversible change. So if the user has a dive that includes > pO₂ values in the samples, we show that dive as CCR. If the user then > switches to OC we can easily clear out the pO₂ values, but of course if > those were not just calculated values but in fact were setpoint data that > the user entered during a dive (i.e., if the switch to OC was a mistake), > then that data is gone. > > I think that's acceptable, but I wanted to run this by others before > pushing that patch. > > With the two patches that I have (one for libdivecomputer, one for > Subsurface), the bug the user reported won't happen again and the files he > has already downloaded can be fixed, so I think this is "about right" for > fixing the situation in 4.4.
Actually, since I had some time, I just pushed three patches for Subsurface that I think make this situation better and that could be included in a 4.4.1. I'd appreciate if someone would take a look and tell me if I'm completely off my meds :-) /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
