On 7 Feb 2015 22:10, "Robert C. Helling" <hell...@atdotde.de> wrote: > > Dirk, > >> On 07 Feb 2015, at 17:10, Dirk Hohndel <d...@hohndel.org> wrote: >> >> I have a draft patch that does that but wanted to talk to you about it. >> This is a non-reversible change. So if the user has a dive that includes >> pO₂ values in the samples, we show that dive as CCR. If the user then >> switches to OC we can easily clear out the pO₂ values, but of course if >> those were not just calculated values but in fact were setpoint data that >> the user entered during a dive (i.e., if the switch to OC was a mistake), >> then that data is gone. >> >> I think that's acceptable, but I wanted to run this by others before >> pushing that patch. > > > here i a bit more careful version of the deletion of pO2 data. > > > > I wrote it in a bit of a hurry, so I am not 100% sure I get the gas calculation right. Please double check! > > Best > Robert > > _______________________________________________ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > I'm talking way over my level here, but instead of trying to figure out CCR or OK, maybe have a drop box in the download dialog where this can be set and then store it for future dives with the given computer? If a tag is set in the XML for the dives, then no information needs to be discarded. Worst case, the drop box can be changed before downloading the batch of dives. Or maybe even have it for each individual dive in the dialog box to select which dives to save? In that case, store the last selected value for setting the drop box when the dialog is next opened?
Benjamin
_______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
