On Mon, Mar 23, 2015 at 05:50:07PM +0200, Claudiu Olteanu wrote: > All of them are used locally. If you believe that it will be helpful I can > write a detailed report about each free call and the reason I used it.
I usually prefer small, obvious patches with good commit messages. But that doesn't mean that you need to do "detailed reports". My comment below was more generic in nature, I haven't had the time to make sure that none of these have unintended side effects. /D > On Mon, Mar 23, 2015 at 5:39 PM, Dirk Hohndel <d...@hohndel.org> wrote: > > > On Sun, Mar 22, 2015 at 01:48:43PM +0200, Claudiu Olteanu wrote: > > > Hello, > > > > > > This patch fixes some memory leaks from datatrak implementation. > > > > The reason I haven't applied these is simple. > > > > Having these allocations hang around can be annoying and creates noise in > > the valgrind output, but isn't causing bugs. > > > > But freeing pointers that are actually still used elsewhere can cause > > massively annoying and hard to fix bugs. > > > > So every single one of these needs to be very carefully looked at. > > > > /D > > _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface