On Saturday 18 July 2015 23:55:35 Claudiu Olteanu wrote: > Subject: [PATCH 3/8] Don't block the save button for Bluetooth device > selection > > After commit #69a75fed05fc3 we don't need to block the save
Dirk, please remember to update the commit SHA-1 after you cherry-pick patch 1 :-) > Subject: [PATCH 4/8] Add combobox for Bluetooth local device selection > > Add a combobox which can be used to list/select the available > local Bluetooth devices. In this way, if a user has more > than one local Bluetooth devices (integrated, dongles, etc.) > he can choose which one he wants to use. > > Before this patch, only the default local Bluetooth device > could be used. Claudiu, most people only have one local bluetooth device. We shouldn't display a list to select an entry if there's only one entry to be selected. Can you hide the list if the list contains only one? > Subject: [PATCH 4/8] Add combobox for Bluetooth local device selection > +void BtDeviceSelectionDialog::localDeviceChanged(int index) > +{ > + QBluetoothAddress localDeviceSelectedAddress = > ui->localSelectedDevice->itemData(index, > Qt::UserRole).value<QBluetoothAddress>(); Where is this deleted? Does QBluetoothLocalDevice take ownership? > + > + // Delete the old localDevice > + if (localDevice) > + delete localDevice; Hint: no need to check for null before deleting. Delete does that for you. > + > + // Create a new local device using the selected address > + localDevice = new QBluetoothLocalDevice(localDeviceSelectedAddress); > + case QBluetoothDeviceDiscoveryAgent::PoweredOffError: > + errorDescription = QString("The Bluetooth adaptor is powered > off, power it on before doing discovery."); + break; > + case QBluetoothDeviceDiscoveryAgent::InputOutputError: > + errorDescription = QString("Writing or reading from the > device resulted in an error."); + break; > + default: > + errorDescription = QString("An unknown error has > occurred."); > + break; > + } > + > + ui->dialogStatus->setText(QString("Device discovery error: > %1.").arg(errorDescription)); All of those QString() should be tr() so they cna be translated. I haven't checked previous patches for this... > +#elif defined(Q_OS_ANDROID) || (QT_VERSION >= 0x050500 && > (defined(Q_OS_IOS) || defined(Q_OS_OSX))) Hint: Q_OS_DARWIN and Q_OS_MAC also mean Q_OS_IOS || Q_OS_OSX. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface