On Sunday 19 July 2015 22:23:46 Claudiu Olteanu wrote: > > Claudiu, most people only have one local bluetooth device. We shouldn't > > display a list to select an entry if there's only one entry to be > > selected. > > Can you hide the list if the list contains only one? > > Of course I can do. One of the attached patches (#0009) should do the trick.
Thanks. The other patches look good too. > > Where is this deleted? Does QBluetoothLocalDevice take ownership? > > This information should remain until the widget is destroyed. I thought > that it will be automatically deleted when I delete the *ui *instance. > Should I > manually clean his children? Child QObjects don't need to be cleaned. But I'm not seeing any parent-child relationship here. I'm deferring to you here. I'm just pointing out, I haven't done any investigation. Would you like me to? > > All of those QString() should be tr() so they cna be translated. I haven't > > checked previous patches for this... > > None of the patches uses tr() . I will create a patch in the end which will > do the > translations. Ok. > > > +#elif defined(Q_OS_ANDROID) || (QT_VERSION >= 0x050500 && > > > (defined(Q_OS_IOS) || defined(Q_OS_OSX))) > > > > Hint: Q_OS_DARWIN and Q_OS_MAC also mean Q_OS_IOS || Q_OS_OSX. > > I saw that Q_OS_MAC doesn't include the open source version and I didn't > know which is that :). Huh? #if defined(Q_OS_DARWIN) # define Q_OS_MAC [...] # if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE # define Q_OS_IOS # elif defined(TARGET_OS_MAC) && TARGET_OS_MAC # define Q_OS_OSX # define Q_OS_MACX // compatibility synonym # endif #endif -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface