Good morning.

There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a
good translation:


       ui->dialogStatus->setText(tr("The local Bluetooth device was turned
%1.")
                                 .arg(on? "ON" : "OFF"));

as "turn on" translates to a word and "turn off" to another.  In other
languages there will probably be the same issue.

In spanish i've translated to:

       "El dispositivo bluetooth local ha sido %1."

An then translated "ON" to "ACTIVADO" and "OFF" to "DESACTIVADO" but this
strings should be passed to translation too.

Salva.
From 5d2eac178cc3347275c76b054c88753437acd349 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Salvador=20Cu=C3=B1at?= <salvador.cu...@gmail.com>
Date: Sat, 5 Sep 2015 11:01:17 +0200
Subject: [PATCH] Add ON and OFF strings to translation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

In btdeviceselectiondialog.cpp ON and OFF strings need to be
translatables to avoid issues in the translation of the resulting
displayed string, as "turn on" and "turn off" translates to a single
word in most languages.

Signed-off-by: Salvador Cuñat <salvador.cu...@gmail.com>
---
 qt-ui/btdeviceselectiondialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qt-ui/btdeviceselectiondialog.cpp b/qt-ui/btdeviceselectiondialog.cpp
index a2c6764..75a7bea 100644
--- a/qt-ui/btdeviceselectiondialog.cpp
+++ b/qt-ui/btdeviceselectiondialog.cpp
@@ -199,7 +199,7 @@ void BtDeviceSelectionDialog::hostModeStateChanged(QBluetoothLocalDevice::HostMo
 	bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff);
 
 	ui->dialogStatus->setText(tr("The local Bluetooth device was turned %1.")
-				  .arg(on? "ON" : "OFF"));
+				  .arg(on? tr("ON") : tr("OFF")));
 	ui->deviceState->setChecked(on);
 	ui->scan->setEnabled(on);
 #endif
-- 
2.5.1

_______________________________________________
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Reply via email to