On Tue, Sep 08, 2015 at 01:06:57PM +0200, Willem Ferguson wrote: > > There are three issues with this patch: > > 1) I did not mention that I replaced five images to reflect the latest UI
That should be in the commit message. Easy enough for me to add. But you can always reword the commit message if you notice something like this. For the very last commit simply with git commit --amend and for earlier commits that you haven't sent me, yet, with git rebase -i SHAOfTheCommitYouWantToReword^ <<- this has a '^' after the SHA then replace the 'pick' in front of any commit you want to reword with 'r' git will prompt you to edit those commit messages > 2) DIRK, please look through the patch file carefully to see what makes > sense. I did not change the Spanish translation at all. I am very scared > of data corruption. If you would like me to do anything with this, > please issue an instruction and I will oblige. When you replace pictures and the picture file name changes you should delete the old pictures. Otherwise we have more and more old pictures in the sources. It would be nice to then go in and change the references to those pictures in the translations, but I'd say that's optional - as long as you mention this in the commit message I'm sure the translators will be happy to track this. I notice the diff touches the Spanish translation anyway. I'll take a look and make sure nothing gets lost before I commit this. > 3) Please check the text about location management under data logging > from a dive computer (should be point 5.2.4). It seems like a > rediculously short explanation for a very labour intensive addition to > the UI. I am certifiably TERRIBLE at writing documentation. Can others please check the manual and make suggestions to Willem? Thanks /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface