On Saturday, March 12, 2016 09:22:54 Dirk Hohndel wrote: > On Mar 12, 2016, at 7:38 AM, Sebastian Kügler <se...@kde.org> wrote: > > On Friday, March 11, 2016 03:00:26 Tomaz Canabrava wrote: > error messages in red. > > Brrrrr. Encapsulate that in a small method? So it can be more easily changed > without editing a lot of HTML in translated messages that would all have to > be re-checked if the HTML bits change? (Also less prone to errors by > translators.) > > Did you have a chance to look at the version of that patch that actually > made it upstream? I didn't use a function but a macro instead and kept > all the markup outside of the translated strings. Maybe not as elegant > as a function, but I think it reaches the same goals as you had in mind... > > commit fcb308fdf2be > > the diff in our git web (with shortened as the URL was >100 chars) > > http://bit.ly/24WQWgR
No, I just read the patch in the email. The commit looks better, aside from the occurrences in appendTextToLog(...) calls. I think they should be replaced with the macro as well. Cheers, -- sebas Sebastian Kügler | http://vizZzion.org | http://kde.org _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface